-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inmemory store cannot clean up localstorage if localstorage is full at the start of the session #23
Comments
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Nov 11, 2020
…ed different test for reclaim engine access
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Nov 11, 2020
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Nov 11, 2020
…function which gets immediately called and set in a var for reuse
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Mar 11, 2021
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Mar 11, 2021
…ed different test for reclaim engine access
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Mar 11, 2021
Dahaden
pushed a commit
to Dahaden/localstorage-retry
that referenced
this issue
Mar 11, 2021
…function which gets immediately called and set in a var for reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Carrying on from #20
When creating an instance of localstorage-retry, Store will grab the defaultEngine and use this for the
originalEngine
which is used to drive the reclaim mechanismMy assumption inside of the last PR was that
defaultEngine
would always be localstorage. However, engine runs a check and assigns the store to localstorage or inmemory before the module is resolved.This means, if localstorage is so full that we cant insert a uuid and "test_value", then we will only ever run reclaim against the inmemory engine.
The text was updated successfully, but these errors were encountered: