Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topicctl bug fix for offsets #171

Merged
merged 4 commits into from
Feb 1, 2024
Merged

topicctl bug fix for offsets #171

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c425205
topicctl bug fix for offsets
ssingudasu Dec 13, 2023
a82e229
Bug fixes and test case fixtures
ssingudasu Jan 31, 2024
35f1d40
minor spelling fixture
ssingudasu Feb 1, 2024
0fabb10
Formatting code for bounds.go
ssingudasu Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/messages/bounds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func GetPartitionBounds(
"Moving first offset forward to match min offset (%d)",
minOffset,
)
firstOffset = minOffset
firstOffset = minOffset - 1
}

var firstMessage kafka.Message
Expand Down Expand Up @@ -233,11 +233,18 @@ func GetPartitionBounds(
)
}

log.Debugf(
"Final offsets for %d: %d->%d",
partition,
firstMessage.Offset,
lastMessage.Offset,
)

return Bounds{
Partition: partition,
FirstOffset: firstMessage.Offset,
FirstTime: firstMessage.Time,
LastOffset: lastMessage.Offset,
LastOffset: lastMessage.Offset + 1,
LastTime: lastMessage.Time,
}, nil
}
Expand Down
Loading