add reconnectInterval as parameter #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seime Will you gonna release it? |
|
It was released as part of the merge build :) |
|
Nice!
czw., 14 lis 2024, 21:09 użytkownik Arne Seime ***@***.***>
napisał:
… It was released as part of the merge build :)
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWTLHRDU4XSIAHMFCZC5P32AT7QRAVCNFSM6AAAAABRZPG35OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGMYTKNJVGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a similar issue to the one discussed in issue #25 regarding deep sleep behavior. After some testing, I believe introducing a single parameter could help address these concerns.
In my setup, I created a "smartknob" on ESPHome, which connects to OpenHAB. This device remains in deep sleep 99% of the time, only waking up when picked up. Waiting 20-40 seconds for OpenHAB to ping the device upon waking can be quite inconvenient. To improve this, I've made the ping interval configurable, with a default value of 20 seconds as it was previously.
Please let me know your thoughts on this PR and whether it might help other use cases as well.