Skip to content

Commit

Permalink
fix: Address further review comments, use Hirschmann solidus by default
Browse files Browse the repository at this point in the history
  • Loading branch information
adigitoleo committed Jun 6, 2024
1 parent bbd9b43 commit 3b4cbac
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 5 additions & 1 deletion src/pydrex/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class DeformationRegime(IntEnum):
The mechanism of deformation that dominates accommodation of plastic deformation
depends in general both on material properties such as grain size and mineral phase
content as well as on thermodynamic properties such as temperature, pressure and
water content (via its fugacity).
water fugacity.
The activity of diffusive mechanisms depends more strongly on grain size, whereas
that of dislocation mechanisms depends more strongly on temperature. High
Expand All @@ -70,6 +70,10 @@ class DeformationRegime(IntEnum):
[Garel et al. 2020](http://dx.doi.org/10.1016/j.epsl.2020.116243) and
[Demouchy et al. 2023](http://dx.doi.org/10.2138/gselements.19.3.151).
.. note:: Although a draft texture evolution behaviour is implemented in the
`frictional_yielding` regime, it is experimental and not yet configurable via
the parameter interface.
"""

min_viscosity = 0
Expand Down
6 changes: 5 additions & 1 deletion src/pydrex/minerals.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,19 @@ def __iter__(self):
"""


def peridotite_solidus(pressure, fit="Herzberg2000"):
def peridotite_solidus(pressure, fit="Hirschmann2000"):
"""Get peridotite solidus (i.e. melting) temperature based on experimental fits.
Pressure is expected to be in GPa.
"""
match fit:
case "Herzberg2000":
# https://doi.org/10.1029/2000GC000089
return 1086 - 5.7 * pressure + 390 * np.log(pressure)
case "Hirschmann2000":
# https://doi.org/10.1029/2000GC000070
return 5.104 * pressure**2 + 132.899 * pressure + 1120.661
case _:
raise ValueError("unsupported fit")

Expand Down

0 comments on commit 3b4cbac

Please sign in to comment.