Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2D simple shear CI tests #116

Merged
merged 30 commits into from
Jul 24, 2023
Merged

Update 2D simple shear CI tests #116

merged 30 commits into from
Jul 24, 2023

Conversation

adigitoleo
Copy link
Member

Closes #110.

Uses symmetry diagnostic instead of expensive strength diagnostics which still require further clarification.

Need to convince ourselves that the remaining differences from Kaminski 2001 and 2004 are justified:

  • For the GBM test, max. difference is about 5.7 degrees, we don't reach 0 degrees at the 200% strain cutoff
  • For the GBS test, the parameter is mostly influencing point-symmetry but only slightly slowing down rotation of the mean a-axis, not by 10+ degrees after 200% strain. Our a-axis also rotates immediately without the initial stagnation (there is no theoretical grounds for the initial stagnation I believe).

@adigitoleo
Copy link
Member Author

adigitoleo commented Jul 20, 2023

Quirky IndexError reproduces on cosgrove (ubuntu, Python 3.11.3) but not for me (Arch and Void, 3.11.4). Can also reproduce, something about the pytest CLI flags, it wants the --outdir?.

Copy link
Member

@Patol75 Patol75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! Let me have a look at the CI failure.

src/pydrex/minerals.py Show resolved Hide resolved
src/pydrex/utils.py Outdated Show resolved Hide resolved
@Patol75
Copy link
Member

Patol75 commented Jul 21, 2023

Current CI reports two minimal rtol violations and two memory allocation errors. For the latter, they are likely related to the number of grains increasing from 3375 to 4394. Either decrease it or use float32 for that specific test; what do you think?

@adigitoleo
Copy link
Member Author

Current CI reports two minimal rtol violations and two memory allocation errors. For the latter, they are likely related to the number of grains increasing from 3375 to 4394. Either decrease it or use float32 for that specific test; what do you think?

It's one of each, the pytest "capture" output makes errors look duplicated. The number of grains matches the value in the GBS paper (Kaminski & Ribe, 2004, section 4.1 second line) but since there are bigger issues at the moment with matching the GBS results maybe decreasing is fine.

adigitoleo and others added 26 commits July 24, 2023 11:43
Much reproducibility! Such convergence! Very wow!
Fixes the grain boundary sliding routine to match what is defined in the
original fortran, where dotacs and rot are set to zero for grains that
are sliding, i.e. there is zero rotation _rate_, but not resetting the
whole orientation matrix to the initial one. Now simply carries over the
previous orientation.

Also adds symmetry asserts to the GBS test.
@adigitoleo
Copy link
Member Author

Either decrease it or use float32 for that specific test; what do you think?

Because the tests are now converted to ensemble tests that take a long time, I have disabled them by default and they must be enabled by passing the --runslow flag to pytest, so for now I'm leaving the number of grains as is (running the ensemble has higher memory requirements anyway).

@adigitoleo adigitoleo changed the title Finalise 2D simple shear CI tests Update 2D simple shear CI tests Jul 24, 2023
@adigitoleo adigitoleo marked this pull request as ready for review July 24, 2023 02:14
@Patol75 Patol75 merged commit 8ac87ee into seismic-anisotropy:main Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A-type olivine in 2D simple shear
2 participants