-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2D simple shear CI tests #116
Conversation
Quirky IndexError reproduces on cosgrove (ubuntu, Python 3.11.3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! Let me have a look at the CI failure.
Current CI reports two minimal |
It's one of each, the pytest "capture" output makes errors look duplicated. The number of grains matches the value in the GBS paper (Kaminski & Ribe, 2004, section 4.1 second line) but since there are bigger issues at the moment with matching the GBS results maybe decreasing is fine. |
Much reproducibility! Such convergence! Very wow!
Fixes the grain boundary sliding routine to match what is defined in the original fortran, where dotacs and rot are set to zero for grains that are sliding, i.e. there is zero rotation _rate_, but not resetting the whole orientation matrix to the initial one. Now simply carries over the previous orientation. Also adds symmetry asserts to the GBS test.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Because the tests are now converted to ensemble tests that take a long time, I have disabled them by default and they must be enabled by passing the |
Closes #110.
Uses symmetry diagnostic instead of expensive strength diagnostics which still require further clarification.
Need to convince ourselves that the remaining differences from Kaminski 2001 and 2004 are justified: