Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Migrate from flake8 to ruff #128

Merged
merged 4 commits into from
Aug 3, 2023
Merged

dev: Migrate from flake8 to ruff #128

merged 4 commits into from
Aug 3, 2023

Conversation

adigitoleo
Copy link
Member

Faster linting and ruff also supports pyproject.toml configuration. Also moves all configuration for other dev tools to pyproject.toml.

Copy link
Member

@Patol75 Patol75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo address is incorrect (https://beta.ruff.rs/docs/usage/).

Nice find by the way!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
adigitoleo and others added 2 commits August 3, 2023 17:06
Faster linting and ruff also supports pyproject.toml configuration.
Also moves all configuration for other dev tools to pyproject.toml.
@Patol75
Copy link
Member

Patol75 commented Aug 3, 2023

So we are getting a few E501: up to you if you want to fix or ignore them.
And you probably need to skip *.*vtu globally in the YAML.

Patol75
Patol75 previously approved these changes Aug 3, 2023
@adigitoleo
Copy link
Member Author

Got rid of the line length errors and I think I've put back the vtu exclude now, hopefully no typos, just waiting on the pre-commit job to do its thing again.

Copy link
Member

@Patol75 Patol75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that one.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@Patol75
Copy link
Member

Patol75 commented Aug 3, 2023

You also need to revert the changes to src/pydrex/data/steadyflow/corner2d_2cmyr_5e5x1e5.vtu.

@Patol75 Patol75 merged commit a5ce779 into seismic-anisotropy:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants