Fixes to test figure output and multi-platform support #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Patol75
previously approved these changes
Oct 18, 2023
This reverts commit 37c9a10.
Patol75
previously approved these changes
Oct 18, 2023
Patol75
previously approved these changes
Oct 18, 2023
adigitoleo
force-pushed
the
visualisation
branch
from
350b7c8
to
6d2ff35
Compare
adigitoleo
force-pushed
the
visualisation
branch
from
6d2ff35
to
e87773a
Compare
|
Failing on Windows because of strangely large memory commits from scipy integrators (switching back to RK45 doesn't help). Tempted to drop Windows support for now. Potentially related to the SciPy BLAS being different on windows (I think?) or maybe an actual SciPy integrator bug on windows. MacOS is passing. |
|
Strange indeed! What about modifying the YAML according to what SciPy has? For example, they use |
|
Perhaps drop Windows for now. It could just be running out of memory. Not quite sure why that would not be the case on Ubuntu though. |
Patol75
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
venv_install.shscript supportPYTHON_BINARYfor using custom paths to local Python installations (e.g. 3.11 on cosgrove)