Fluidity advection 2d #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
from
a143110
to
22a24a3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
3 times, most recently
from
bd3c650
to
dc4de76
Compare
|
Tracked it down: docs failure is still caused by gmsh import, the workaround from 2d30d91 doesn't fix it. Since the gmsh package is so much trouble I'll just move it to an optional dep and make the mesh generation functionality unavailable by default. |
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
2 times, most recently
from
de1af2c
to
82f19db
Compare
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
3 times, most recently
from
d6a98d0
to
a4e866c
Compare
|
Manual exclusion of the |
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
2 times, most recently
from
4106f86
to
2ee5e3f
Compare
|
Fluidity now seems to produce the correct results. More on this later today. Might want to squash some of this stuff before merge. |
Patol75
previously approved these changes
Mar 25, 2024
The mesh generator relies on gmsh which is installed as an optional dependency. `import gmsh` crashes the pdoc github runner though for some reason so needs to be excluded. The old h5part reader script is removed and replaced with a first-class CLI tool as well, which makes testing easier.
The default, generated by `@dataclass`, is not useful here because of the complicated data structure.
- `add_dim` for converting from e.g. a 2D matrix to a 3D version - `remove_dim` for converting from e.g. a 3D matrix to a 2D version They also work for vectors or arbitrary-dimension ndarrays.
And modify simple shear `dudz_pathline` test to use the same parameters.
adigitoleo
force-pushed
the
fluidity-advection-2d
branch
from
0fb296b
to
d92aa82
Compare
Patol75
approved these changes
Mar 25, 2024
adigitoleo
added a commit
that referenced
this pull request
Mar 26, 2024
A few cleaning chores I missed in #174.
adigitoleo
added a commit
that referenced
this pull request
Mar 27, 2024
A few cleaning chores I missed in #174.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fluidity advection example and simple builtin mesh (gmsh) generation.