Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluidity cornerflow 2d example #179

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Add Fluidity cornerflow 2d example #179

merged 13 commits into from
Mar 28, 2024

Conversation

adigitoleo
Copy link
Member

Includes the float32 patch to make M-index calculations less heavy.

@adigitoleo adigitoleo force-pushed the fluidity-cornerflow-2d branch 2 times, most recently from fdebcf2 to 2c92244 Compare March 26, 2024 02:37
@adigitoleo adigitoleo marked this pull request as ready for review March 26, 2024 03:39
@adigitoleo

This comment was marked as resolved.

@adigitoleo

This comment was marked as resolved.

@adigitoleo

This comment was marked as resolved.

Closes #180.

Note that we are now officially `f(t, x)` people. Any use of `f(x, t)`
will be met with scorn and disgust.
@adigitoleo

This comment was marked as resolved.

@adigitoleo
Copy link
Member Author

Confirming that it works (for the 1 pathline) for both M*=10 and M*=125 and results are close to standalone equivalents. Quickly checking if the multi-particle crash has persisted.

@adigitoleo
Copy link
Member Author

Multi-particle is not crashing anymore. I'll push a commit to add the other spawn locations.

@adigitoleo adigitoleo requested a review from Patol75 March 28, 2024 00:47
Copy link
Member

@Patol75 Patol75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one typo ;)

src/pydrex/minerals.py Outdated Show resolved Hide resolved
@adigitoleo adigitoleo merged commit 323de31 into main Mar 28, 2024
4 checks passed
@adigitoleo adigitoleo deleted the fluidity-cornerflow-2d branch March 28, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mineral.update_orientations API should accept time-dependent velocity gradient callables
2 participants