Add multiphase texture update API #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #198. Also rearranges definitions so that globals are above classes are above functions. This allows for mypy type hints of the multiphase function args.
This fix was brought to you by mypy static type linting.
This comment was marked as resolved.
This comment was marked as resolved.
Patol75
reviewed
Jun 17, 2024
adigitoleo
commented
Jun 17, 2024
adigitoleo
commented
Jun 17, 2024
Patol75
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add single-call API for multiphase texture updates
On line 638 of
minerals.py.Closes #198. Also rearranges definitions so that globals are above classes are above functions. This allows for mypy type hints of the multiphase function args.
fix: Update voigt averaging to use new StiffnessTensors API
This fix was brought to you by mypy static type linting.