Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add missing pre-commit executable warning to the venv installer #204

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

adigitoleo
Copy link
Member

Running the pre-commit hooks locally eliminates the need to rebase onto changes that the pre-commit-ci bot commits. This makes the PR process smoother for contributors. But in case someone can't install or build the pre-commit binary, this warning is not fatal to the venv installer.

adigitoleo and others added 2 commits August 1, 2024 00:31
Running the pre-commit hooks locally eliminates the need to rebase onto
changes that the pre-commit-ci bot commits. This makes the PR process
smoother for contributors. But in case someone can't install or build
the pre-commit binary, this warning is not fatal to the venv installer.
@adigitoleo adigitoleo merged commit 912583c into main Jul 31, 2024
10 checks passed
@Patol75 Patol75 deleted the warn-missing-local-precommit branch August 1, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants