Improve default LSODA tolerances #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosening the `atol` tolerance for the main LSODA solver improves performance significantly without failing any of our tests. Because we already modify `atol` based on the initial condition, this change mostly just prevents LSODA from trying to meet unreasonably tight error tolerances for those elements of the solution where the corresponding initial condition is zero. With this improvement we go from being sometimes more than 20x slower than the Fortran (for simple shear, excluding Numba compilation time) to being about 7 or 8 times slower.
|
Also, changing these components of |
Patol75
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosening the
atoltolerance for the main LSODA solver improves performance significantly without failing any of our tests. Because we already modifyatolbased on the initial condition, this change mostly just prevents LSODA from trying to meet unreasonably tight error tolerances for those elements of the solution where the corresponding initial condition is zero. With this improvement we go from being sometimes more than 20x slower than the Fortran (for simple shear, excluding Numba compilation time) to being about 7 or 8 times slower.