-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a RAII PcapHandle wrapper class that manages a Pcap handle. #1532
Merged
tigercosmos
merged 19 commits into
seladb:dev
from
Dimi1010:feature/pcap_handle_wrapper
Aug 22, 2024
Merged
Added a RAII PcapHandle wrapper class that manages a Pcap handle. #1532
tigercosmos
merged 19 commits into
seladb:dev
from
Dimi1010:feature/pcap_handle_wrapper
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1532 +/- ##
==========================================
- Coverage 82.93% 82.92% -0.01%
==========================================
Files 273 273
Lines 46282 46343 +61
Branches 9459 9398 -61
==========================================
+ Hits 38382 38430 +48
- Misses 7056 7084 +28
+ Partials 844 829 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seladb
reviewed
Aug 14, 2024
…o feature/pcap_handle_wrapper
tigercosmos
reviewed
Aug 15, 2024
seladb
reviewed
Aug 16, 2024
tigercosmos
reviewed
Aug 21, 2024
…plementation of 'std::unique_ptr::reset()'
tigercosmos
approved these changes
Aug 22, 2024
seladb
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class
PcapHandle
that wraps apcap_t*
handle and manages the lifecycle of the handle via RAII mechanism, in a similar fashion tostd::unique_ptr
.PS: The diff of PcapDevice.cpp is a bit messed up because the formatter ran on it... might be easier to review after #1516 has been merged.