Rework of PfRingDevice capture thread implementation. #1668
+354
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completely rewrote the capture thread function to be a free function. - Added StopToken and StopTokenSource to encapsulate stop requests. - Refactored startCaptureSingleThread to use startCaptureMultiThread.
Dimi1010
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1668 +/- ##
==========================================
- Coverage 83.16% 83.12% -0.05%
==========================================
Files 277 278 +1
Lines 48193 48212 +19
Branches 9966 9947 -19
==========================================
- Hits 40081 40077 -4
- Misses 7234 7243 +9
- Partials 878 892 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dimi1010
requested review from
clementperon,
seladb,
tigercosmos and
egecetin
|
I don't actually have a system that can run PF_RING. So it would be nice if someone could test it live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1664.
StopTokenandStopTokenSourcethat mirror C++20'sstop_tokenandstop_source.Many variables are now kept on the thread's stack instead of relying on member fields in
PfRindDevice.