-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes a use-of-uninitialized-value in light_pcapng.c #1669
base: dev
Are you sure you want to change the base?
Conversation
Hii @seladb Could You please Review this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1669 +/- ##
==========================================
- Coverage 83.16% 83.15% -0.02%
==========================================
Files 277 277
Lines 48193 48204 +11
Branches 9966 9945 -21
==========================================
+ Hits 40081 40083 +2
+ Misses 7234 7227 -7
- Partials 878 894 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
} | ||
break; | ||
void parse_by_block_type(struct _light_pcapng *current, const uint32_t *local_data, const uint32_t *block_start) { | ||
switch (current->block_type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to follow the original format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing Could you clarify if the concern is solely about formatting or if there are issues with the fix itself? If it’s just formatting, I’ll align it with the original style while keeping the vulnerability fix intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only about the formatting. We try to minimize the change in 3rdParty
because we may merge the latest changes from upstream in the future. However, vulnerability fixes are welcome. Please also leave a comment like // PCPP patch
in your patch so we can easily identify the changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Done you can Review and Ready to Merge
{ // PCPP patch | ||
DPRINT_HERE(LIGHT_SECTION_HEADER_BLOCK); | ||
struct _light_section_header *shb = calloc(1, sizeof(struct _light_section_header)); | ||
struct _light_option *opt = calloc(1, sizeof(struct _light_option)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that esentially leak the memory as opt
is overwritten on L109?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are correct for this here can be used free (opt) Memory Before Reassignment
I had created Commit below
{ // PCPP patch | ||
DPRINT_HERE(LIGHT_INTERFACE_BLOCK); | ||
struct _light_interface_description_block *idb = calloc(1, sizeof(struct _light_interface_description_block)); | ||
struct _light_option *opt = calloc(1, sizeof(struct _light_option)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto: memory leak
|
||
case LIGHT_ENHANCED_PACKET_BLOCK: | ||
{ | ||
DPRINT_HERE(LIGHT_ENHANCED_PACKET_BLOCK); | ||
struct _light_enhanced_packet_block *epb = NULL; | ||
struct _light_option *opt = NULL; | ||
struct _light_option *opt = calloc(1, sizeof(struct _light_option)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto: memory leak
@@ -182,7 +181,7 @@ void parse_by_block_type(struct _light_pcapng *current, const uint32_t *local_da | |||
{ | |||
DPRINT_HERE(LIGHT_CUSTOM_DATA_BLOCK); | |||
struct _light_custom_nonstandard_block *cnb = NULL; | |||
struct _light_option *opt = NULL; | |||
struct _light_option *opt = calloc(1, sizeof(struct _light_option)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto: memory leak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes done some Improvement to memory free(opt) now there wouldn't be any leakage i think
This PR fixes a use-of-uninitialized-value vulnerability in light_pcapng.c. The changes ensure all allocated memory is properly initialized before use, mitigating potential crashes and undefined behavior.
Issue: https://issues.oss-fuzz.com/issues/42536106
Reproducer Testcase: https://oss-fuzz.com/download?testcase_id=6639796737867776