Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(all) Add support of Selectel DNS #1

Merged
merged 18 commits into from
Apr 8, 2024
Merged

feat(all) Add support of Selectel DNS #1

merged 18 commits into from
Apr 8, 2024

Conversation

ormequ
Copy link

@ormequ ormequ commented Mar 22, 2024

Changes:

  • added keystone.Provider for authorization
  • renamed stackit packaged to selectel
  • added work with domains-go to selprovider (renamed from stakcitprovider)
  • added httpdefault package with default HTTP settings
  • changed configs & manifests for Selectel
  • fixed tests

@yaroslaver
Copy link

@kolsean @TawR1024 @pavelpereyma what about CONTRIBUTING.md and LICENSE?

pavelpereyma
pavelpereyma reviewed Mar 28, 2024
View reviewed changes
cmd/webhook/cmd/root.go Outdated Show resolved Hide resolved
internal/selprovider/apply_changes.go Outdated Show resolved Hide resolved
internal/selprovider/apply_changes_test.go Outdated Show resolved Hide resolved
internal/selprovider/rrset_fetcher.go Outdated Show resolved Hide resolved
pkg/keystone/provider.go Outdated Show resolved Hide resolved
pkg/keystone/provider.go Show resolved Hide resolved
internal/selprovider/provider.go Outdated Show resolved Hide resolved
TawR1024
TawR1024 reviewed Mar 29, 2024
View reviewed changes
cmd/webhook/cmd/root.go Outdated Show resolved Hide resolved
@ormequ ormequ changed the title Add support of Selectel DNS feat(all) Add support of Selectel DNS Apr 3, 2024
@ormequ ormequ mentioned this pull request Apr 3, 2024
Merged
kolsean
kolsean reviewed Apr 5, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
TawR1024
TawR1024 approved these changes Apr 8, 2024
View reviewed changes
Copy link

@TawR1024 TawR1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TawR1024 TawR1024 merged commit 155ad16 into selectel:main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelpereyma pavelpereyma pavelpereyma approved these changes

@TawR1024 TawR1024 TawR1024 approved these changes

@kolsean kolsean kolsean approved these changes

@yaroslaver yaroslaver yaroslaver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ormequ @yaroslaver @pavelpereyma @TawR1024 @kolsean