Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.20 #109

Merged
merged 42 commits into from
Dec 20, 2024
Merged

v0.0.20 #109

merged 42 commits into from
Dec 20, 2024

Conversation

qlrd
Copy link
Collaborator

@qlrd qlrd commented Nov 16, 2024

Minor changes on this PR:

  • Coveraged code to about ~99%;
  • fixes error messages when something go wrong during flashes;

qlrd and others added 25 commits October 31, 2024 23:01
moved drive tests to proper folder
@qlrd qlrd requested review from odudex, tadeubas and jdlcdl November 16, 2024 13:00
@qlrd qlrd self-assigned this Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 91.59664% with 10 lines in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (ee8a9ff) to head (a28ab1e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/flasher/flasher.py 25.00% 3 Missing ⚠️
src/utils/flasher/wiper.py 25.00% 3 Missing ⚠️
src/app/screens/ask_permission_dialout_screen.py 0.00% 1 Missing and 1 partial ⚠️
src/app/screens/greetings_screen.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   91.66%   98.92%   +7.25%     
==========================================
  Files          63       63              
  Lines        3084     3152      +68     
  Branches      260      270      +10     
==========================================
+ Hits         2827     3118     +291     
+ Misses        232       19     -213     
+ Partials       25       15      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qlrddev added 3 commits November 21, 2024 12:22
coverage of exception hooks on flash_screen
diminished coverage target and threshold
qlrd added 2 commits November 21, 2024 18:26
added conditional to search for 'fedora' value in /etc/os-release ID variable
@qlrd
Copy link
Collaborator Author

qlrd commented Dec 6, 2024

Fix #115 as mentioned by @ciori

@qlrd qlrd linked an issue Dec 12, 2024 that may be closed by this pull request
@qlrd
Copy link
Collaborator Author

qlrd commented Dec 12, 2024

Fix #116.

@PMK, @theBillLee, @BitCoisas can you review the nl_NL.json, zh_CN.json and jp_JA.json translations for the new entry ("disconnect and reconnect device before flash again")?

"wipe_screen": {
    "PLEASE DO NOT UNPLUG YOUR DEVICE": "PLEASE DO NOT UNPLUG YOUR DEVICE",
    "DONE": "DONE",
    "Back": "Back",
    "Quit": "Quit",
    "disconnect and reconnect device before flash again": "disconnect and reconnect device before flash again"
  },

@PMK
Copy link
Contributor

PMK commented Dec 14, 2024

Fix #116.

@PMK, @theBillLee, @BitCoisas can you review the nl_NL.json, zh_CN.json and jp_JA.json translations for the new entry ("disconnect and reconnect device before flash again")?

"wipe_screen": {
    "PLEASE DO NOT UNPLUG YOUR DEVICE": "PLEASE DO NOT UNPLUG YOUR DEVICE",
    "DONE": "DONE",
    "Back": "Back",
    "Quit": "Quit",
    "disconnect and reconnect device before flash again": "disconnect and reconnect device before flash again"
  },

ACK

@qlrd qlrd linked an issue Dec 15, 2024 that may be closed by this pull request
@BitCoisas
Copy link
Contributor

Fix #116.

@PMK, @theBillLee, @BitCoisas can you review the nl_NL.json, zh_CN.json and jp_JA.json translations for the new entry ("disconnect and reconnect device before flash again")?

"wipe_screen": {
    "PLEASE DO NOT UNPLUG YOUR DEVICE": "PLEASE DO NOT UNPLUG YOUR DEVICE",
    "DONE": "DONE",
    "Back": "Back",
    "Quit": "Quit",
    "disconnect and reconnect device before flash again": "disconnect and reconnect device before flash again"
  },

ACK. The phrase is well-translated and understandable. However, using '再フラッシュ' instead of '再度フラッシュ' makes it sound more natural in technical contexts. Thxx!!!

qlrd and others added 2 commits December 18, 2024 00:55
Copy link
Contributor

@BitCoisas BitCoisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Arigatou!!!

@qlrd qlrd merged commit 471d45a into selfcustody:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants