Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the split method #105

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix the split method #105

merged 1 commit into from
Oct 4, 2023

Conversation

PMohanJ
Copy link
Member

@PMohanJ PMohanJ commented Oct 4, 2023

A small fix at the split method. If the variable meta is None then splitting the message with split(" ") would return a list of length two with second variable as empty string "", thus raising the json decode error.

Screenshot 2023-10-04 at 3 52 41 PM

I've tested this change by creating a python build and now the error is gone.

Copy link
Member

@ehfd ehfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from me. No visible issues.

@ehfd ehfd merged commit 658586f into selkies-project:main Oct 4, 2023
1 check passed
@PMohanJ PMohanJ deleted the patch-2 branch December 24, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants