fix(circle): always prompt for CircleCI API token #278
Conversation
|
@gr2m Anything blocking this? |
| ); | ||
| process.exit(1); // eslint-disable-line unicorn/no-process-exit | ||
| } | ||
| }, |
There was a problem hiding this comment.
I don't quite understand how that change relates to the title of the pull request?
There was a problem hiding this comment.
currently it only prompts for the CircleCI API token when info.options['ask-for-passwords'] is truthy. This change removes that and makes sure it will always prompt for the CircleCI API token, regardless of the ask-for-passwords option (which is not used by anything else anymore). As I mentioned in #277, if it doesn't prompt for the CircleCI API token, it fails with a cryptic error following repo on CircleCI! message.
There was a problem hiding this comment.
Thanks a bunch for getting my PRs merged!
The biggest problem with this package is that it does not have a good testing suite, hence we cannot easily accept contributions. Both Pierre and I don't have much time right now, we could really use some help to get the test coverage up. I don't mind merging the PRs, but it would be really great if you could help us by establishing a test suite so we can move forward faster and with more confidence that we don't break things |
|
@gr2m I see -- unit tests with mocks for all the remote services? |
|
Yes, http mocks for the remote services would be great. You can use nock |
fix #277