Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update semantic-release to version ^24.2.0 #416

Closed
wants to merge 1 commit into from

Conversation

babblebey
Copy link
Member

@babblebey babblebey commented Dec 12, 2024

This pull request updates the package.json file to upgrade the semantic-release package in attempt to bump the semantic-release/github plugin to v11.0.1

Other Changes Made

  • Removed semantic-release from peerDependencies; happened follwoing the uninstallation action to bump the semantic-release version; just thought to keep it that since the devDeps of semantic-release isn't pinned to a certain version anymore with the hope of returning that when beta merges to master

@babblebey babblebey marked this pull request as ready for review December 12, 2024 23:45
@babblebey babblebey requested a review from travi December 12, 2024 23:47
@travi
Copy link
Member

travi commented Dec 13, 2024

a few things to consider with this. this change needs to be in the beta branch, not master. once the other changes in the beta branch get promoted, this sort of change can come along with those. secondly, there should be no need to remove the peer dependencies definition. that is there for consumers and we need to be careful with changes to that since most changes there should be considered breaking. also, small nit-pick: try to make sure that the devDependency remains pinned rather than defined as a range. if installing with the npm cli, the -E or --save-exact flag would accomplish this.

@babblebey
Copy link
Member Author

a few things to consider with this. this change needs to be in the beta branch, not master. once the other changes in the beta branch get promoted, this sort of change can come along with those.

Well noted, I just thought the change might not work immediately for the release at the point of merging... I still think we will be using the version v11.0.0 of semantic-release/github that point of merging beta to master. Good to know its alright though.

secondly, there should be no need to remove the peer dependencies definition. that is there for consumers and we need to be careful with changes to that since most changes there should be considered breaking.

True, that is! I will revert this an see what peer version best suites

try to make sure that the devDependency remains pinned rather than defined as a range. if installing with the npm cli, the -E or --save-exact flag would accomplish this.

✍️

@babblebey
Copy link
Member Author

Now closing this in favour of #417

@babblebey babblebey closed this Jan 5, 2025
@babblebey babblebey deleted the chore/bumb-semantic-release branch January 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants