Skip to content

Commit

Permalink
Update for recent gaplint
Browse files Browse the repository at this point in the history
  • Loading branch information
james-d-mitchell committed Aug 31, 2024
1 parent d03e249 commit 9e06a11
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: "Install dependencies . . ."
run: sudo pip install gaplint==1.1.3
run: sudo pip install gaplint==1.3.2
- name: "Run gaplint . . ."
run: bash etc/gaplint.sh

Expand Down
2 changes: 1 addition & 1 deletion gap/attributes/rms-translat.gi
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ function(T)
od;

for a in group_gens do
fa := function(x)
fa := function(x) # gaplint: disable=W047
if x = 1 then
return a;
fi;
Expand Down
13 changes: 2 additions & 11 deletions gap/elements/maxplusmat.gi
Original file line number Diff line number Diff line change
Expand Up @@ -196,18 +196,9 @@ end);
InstallMethod(UnweightedPrecedenceDigraph, "for a max-plus matrix",
[IsMaxPlusMatrix],
function(mat)
local adj;
# Auxiliary function used to compute the adjacency matrix of the precedence
# digraph
adj := function(i, j)
if mat[i][j] = -infinity then
return false;
else
return true;
fi;
end;
# Generate and return digraph object
return Digraph([1 .. DimensionOfMatrixOverSemiring(mat)], adj);
return Digraph([1 .. DimensionOfMatrixOverSemiring(mat)],
{i, j} -> mat[i][j] <> -infinity);
end);

## Method from lemma 19, page 36, of:
Expand Down
4 changes: 2 additions & 2 deletions gap/main/lambda-rho.gi
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function(o, m, i)
genpos := ReverseSchreierTreeOfSCC(o, m);
inv := LambdaInverse(o!.parent);

trace := function(i) # gaplint: disable=W000
trace := function(i) # gaplint: disable=W047
local x;
if IsBound(mults[i]) then
return mults[i][2];
Expand Down Expand Up @@ -366,7 +366,7 @@ function(o, m)
genpos := SchreierTreeOfSCC(o, m);
inv := x -> RhoInverse(o!.parent)(o[scc[1]], x);

trace := function(i) # gaplint: disable=W000
trace := function(i) # gaplint: disable=W047
local x;
if IsBound(mults[i]) then
return mults[i][1];
Expand Down

0 comments on commit 9e06a11

Please sign in to comment.