Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the coverage reports? #844

Open
olexandr-konovalov opened this issue Jun 22, 2022 · 4 comments
Open

Where are the coverage reports? #844

olexandr-konovalov opened this issue Jun 22, 2022 · 4 comments
Labels
question A label for issues that are questions

Comments

@olexandr-konovalov
Copy link
Contributor

https://app.codecov.io/gh/semigroups/Semigroups/ shows code coverage checks - but why they are not reported as comments in pull requests? Maybe @fingolfin knows?

@wilfwilson
Copy link
Collaborator

Because such comments are turned off in the .codecov.yml file. They're easy enough to turn on again.

@james-d-mitchell
Copy link
Collaborator

They seem to be back!

@james-d-mitchell james-d-mitchell added the question A label for issues that are questions label Jun 23, 2022
@james-d-mitchell
Copy link
Collaborator

I'd prefer that PR's not fail because of insufficient coverage because it's a bit flaky, if that's also possible?

@fingolfin
Copy link
Contributor

Yes; you can also set a threshold, so that a failure is only declared if the coverage falls more than that threshold. See https://docs.codecov.com/docs/common-recipe-list which even has examples for just this case

@james-d-mitchell james-d-mitchell changed the title Where are the coverage reports Where are the coverage reports? Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A label for issues that are questions
Projects
None yet
Development

No branches or pull requests

4 participants