Add FreeSemilattice constructor #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
james-d-mitchell
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
I think the only question I have is should the returned semilattice have 2^n elements or (2^n) - 1 elements as you've implemented? @Jun2M can you possibly say why you chose this approach?
Otherwise this looks great!
james-d-mitchell
added
the
waiting-for-creator-input
|
@Jun2M I don't think the CI tests failing are anything to do the changes in your PR, there seems to be an issue with GAP at the moment: |
james-d-mitchell
added
Re-run ci
|
CI re-run after gap-system/gap#5672 closed. Fingers crossed... |
james-d-mitchell
removed
the
Re-run ci
|
The check was not successful because the test for NumberOfLeftCongruences failed? I don't think I touched that code at all..? |
|
Probably just a spurious error, running it again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new constructor for the FreeSemilattice class. The constructor takes a positive integer as input and creates a FreeSemilattice object based on the specified semigroup type. The constructor supports various semigroup types such as IsFpSemigroup, IsTransformationSemigroup, and IsPartialPermSemigroup. This addition enhances the functionality of the FreeSemilattice class and provides more flexibility in creating semilattices.