Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing framework in version prefix builder #38

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Aug 1, 2024

jira version 자동으로 추출하는 부분에 framework 처리가 안돼있어서 수정했습니다.

@bang9 bang9 self-assigned this Aug 1, 2024
@bang9 bang9 requested review from lookdeceline and hoon-sung August 1, 2024 01:38
@bang9 bang9 force-pushed the fix/version-prefix branch from 5800bf8 to b91f3a8 Compare August 1, 2024 01:39
@bang9 bang9 force-pushed the fix/version-prefix branch from b91f3a8 to 5f6305a Compare August 1, 2024 01:42
Copy link
Contributor

@hoon-sung hoon-sung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@lookdeceline lookdeceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
README에 slack message 관련해서도 설명 추가해두면 어떨까요?

@bang9
Copy link
Collaborator Author

bang9 commented Aug 1, 2024

@lookdeceline 굿아이디아. 추가했습니다!

@bang9 bang9 merged commit 316233e into main Aug 1, 2024
4 checks passed
@bang9 bang9 deleted the fix/version-prefix branch August 1, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants