Added unset-not-found flag #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,22 +36,24 @@ type LimitedParamsGetter interface { | |||
| // given value prefix, using the given ParamsGetter. | |||
| // | |||
| // NewReplacer will panic if envValuePrefix is the empty string. | |||
| func NewReplacer(envValuePrefix string, ssm ParamsGetter) *Replacer { | |||
| func NewReplacer(envValuePrefix string, unsetNotFound bool, ssm ParamsGetter) *Replacer { | |||
There was a problem hiding this comment.
This changes the function signature, and thus would represent a breaking change. We could instead just expose UnsetNotFound on the Replacer struct, so that it can be set to true after calling NewReplacer; adding new fields to a struct is not considered a breaking change by the Go community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we want to pass env variables that might not be present in AWS SSM Param store but could be added later. This flag lets you ignore such variables and unset them in the environment.