Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers() needs to use textproto.Mimeheader.Set() instead of modifying the map directly #43

Open
ericychoi opened this issue Mar 24, 2023 · 2 comments

Comments

@ericychoi
Copy link
Contributor

https://github.com/sendgrid/go-gmime/blame/5544c54b141c13fa6ac0b4ddc162a65dab1dc8bb/gmime/envelope.go#L64

When Canonical form of the key is different from the actual key, headers().Values() would not return the right value, since the internal map doesn't have the canonical form as the key. Users can get the values by treating Mimeheader as a map as a workaround- but this is confusing and can cause unexpected consequences.

@naspeh
Copy link
Contributor

naspeh commented Jul 4, 2024

I've created PR #47 for fixing this.

@naspeh
Copy link
Contributor

naspeh commented Aug 12, 2024

@ericychoi @xdsxc this can be closed, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants