Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResponseError typescript compile errors #1413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geofflangenderfer
Copy link

@geofflangenderfer geofflangenderfer commented Aug 17, 2024

Fixes

this PR updates the types for the ResponseError class. Previously, this caused typescript compiler failures that require casting this to any type.

Type error: Property 'toJSON' does not exist on type 'ResponseError'.
  48 |                 console.error(error)
  49 |                 if (error instanceof ResponseError) {
> 50 |                     res.status(error.code).json(error.toJSON());
     |                                                       ^
  51 |                 } else if (error instanceof Error) {
  52 |                     const errorMessage = error.message
  53 |                     res.status(500).json({ message: errorMessage });
Error: Command "npm run build" exited with 1

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

this was missing a lot from the javascript class. It should now reflect
what's available in the class. And it should stop typescript compile
errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant