Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change display splash to senseBox logo #120

Merged
merged 3 commits into from
Dec 20, 2024
Merged

change display splash to senseBox logo #120

merged 3 commits into from
Dec 20, 2024

Conversation

mariopesch
Copy link
Member

copy senseBox splash to the display library

@felixerdy
Copy link
Member

Please add it to the Dockerfile.test as well, just to also have it in the test environment

#define splash2_width 115
#define splash2_height 32

const uint8_t PROGMEM splash2_data[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the Adafruit Logo from the original library?

If so please replace it with a senseBox logo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splash2_data is still the adafruit logo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please add a senseBox logo for splash2_data too.

Copy link

test: Run #179

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
17 17 0 0 0 0 0 1m17s

🎉 All tests passed!

Github Test Reporter

@felixerdy felixerdy merged commit 915a44c into main Dec 20, 2024
2 checks passed
@felixerdy felixerdy deleted the change-splash branch December 20, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants