fix: use valid type for webhook configuration example

sensiolabs · Jan 14, 2025 · f78341a · f78341a
1 parent 1ca1aaa
commit f78341a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -752,9 +752,11 @@ private function addWebhookConfigurationNode(string $name): NodeDefinition
             ->children()
                 ->scalarNode('url')
                     ->info('The URL to call.')
+                    ->example('https://webhook.site/#!/view/{some-token}')
                 ->end()
-                ->variableNode('route')
+                ->arrayNode('route')
                     ->info('Route configuration.')
+                    ->example(['my_route', ['param1' => 'value1', 'param2' => 'value2']])
                     ->beforeNormalization()
                         ->ifArray()
                             ->then(function (array $v): array {
@@ -771,10 +773,7 @@ private function addWebhookConfigurationNode(string $name): NodeDefinition
                         })
                         ->thenInvalid('The "route" parameter must be a string or an array containing a string and an array.')
                     ->end()
-                    ->example([
-                        'https://webhook.site/#!/view/{some-token}',
-                        ['my_route', ['param1' => 'value1', 'param2' => 'value2']],
-                    ])
+                    ->variablePrototype()->end()
                 ->end()
                 ->enumNode('method')
                     ->info('HTTP method to use on that endpoint.')

diff --git a/tests/DependencyInjection/SensiolabsGotenbergExtensionTest.php b/tests/DependencyInjection/SensiolabsGotenbergExtensionTest.php
@@ -513,6 +513,7 @@ public function testBuilderWebhookConfiguredWithValidConfiguration(): void
                 'foo' => [
                     'success' => [
                         'url' => 'https://sensiolabs.com/webhook',
+                        'route' => [],
                         'method' => null,
                     ],
                     'error' => [
@@ -531,6 +532,7 @@ public function testBuilderWebhookConfiguredWithValidConfiguration(): void
                 '.sensiolabs_gotenberg.pdf_builder.markdown.webhook_configuration' => [
                     'success' => [
                         'url' => 'https://sensiolabs.com/webhook-on-the-fly',
+                        'route' => [],
                         'method' => null,
                     ],
                     'error' => [