Skip to content

Commit

Permalink
Minor tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
eonist committed Nov 24, 2024
1 parent ae587ca commit 03ebaa7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@ Rectangle()
```Swift
.package(url: "https://github.com/sentry.co/BlurView", branch: "main")
```

## Todo:
- A current limitation is that macOS cant match background color with translucent tint color. Unlike iOS where this library has support for that. But I think we solved that in legacy, So look for that solution and recreate here. If there is no solution. Stick with OS provided background colors, which match the translucent. Or add an underlay that does not cover the overlay area.
1 change: 1 addition & 0 deletions Sources/BlurView/effect/DebugHeaderView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ struct DebugHeaderView: View {
/**
* - Important: ⚠️️ It seems best to leave the background color to be decided by the operating system. It matches better with the translucent tint. Custom background colors creates more visible seems.
* - Fixme: ⚠️️ Look into how this was done in legacy. Legacy supported any custom background color I think.
* - Fixme: ⚠️️ To avoid seem we can add an underlay that does not cover the overlay area?
*/
var body: some View {
ZStack(alignment: .top) {
Expand Down

0 comments on commit 03ebaa7

Please sign in to comment.