More wildcard tests #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unclear why the tests are failing in Travis. These pass locally and the build in Travis won't show the logs. I'll investigate more later. |
|
It uses a python module The |
b4hand
force-pushed
the
wildcard-tests
branch
from
dce83d9
to
208dbf4
Compare
sistawendy
approved these changes
Feb 12, 2018
| Rep::Directive parsed(directive, true); | ||
| for (auto example : examples) | ||
| { | ||
| EXPECT_TRUE(parsed.match(example)) << |
There was a problem hiding this comment.
I'm not a fan of assertions in loops, but this should cover what you want covered.
There was a problem hiding this comment.
Normally, I wouldn't do this, but the other tests in this suite were already written the same way.
There was a problem hiding this comment.
Yeah... apologies about that :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were added as part of the initial investigation into #34, but don't directly address the issue reported there. It turns out the bug is only triggered when the wildcard is in the leading position and only occurs in the
Agent, not in theDirective.I have some separate failing tests that directly address the bug mentioned in #34, but I'm waiting to submit a PR until I have a fix.