Fix broken Cython compilation due to baked C++ files #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having C++ files for users without Cython is nice, but when people actually use Cython it introduces multiple things:
--force
without a relevant reason in this case)pip
to utilize source code because the source code is already broken by the generated code even if the repo itself already contains a fixWhat's happening is basically this:
This might have implications on caching of the result when developing the package when having multiple files, however since there is pretty much a single
.pyx
file I believe this implication is redundant and the overall dev-experience improves by having a straightforward solution.Attached is the
tee
-d output: reppy-output.txtCloses #122