Merge pull request #169 from smehringer/stdin

[FIX] Do not consume std::cin in interactive mode.

include/sharg/detail/terminal.hpp

@@ -38,7 +38,7 @@ namespace sharg::detail
 inline bool is_terminal()
 {
 #ifndef _WIN32
-    return isatty(STDOUT_FILENO);
+    return isatty(STDIN_FILENO);
 #else
     return false;
 #endif

include/sharg/detail/version_check.hpp

@@ -361,17 +361,18 @@ class version_checker
 )";
             std::string line{};
             std::getline(std::cin, line);
-            line.resize(1); // ignore everything but the first char or resizes the empty string to the default
+            line.resize(1, 's'); // ignore everything but the first char or resizes the empty string to the default
 
             switch (line[0])
             {
             case 'y':
             {
                 return true;
             }
-            case 's':
+            case 'a':
             {
-                return false;
+                write_cookie(std::string{"ALWAYS"}); // overwrite cookie
+                return true;
             }
             case 'n':
             {
@@ -380,23 +381,13 @@ class version_checker
             }
             default:
             {
-                write_cookie(std::string{"ALWAYS"}); // overwrite cookie
-                return true;
+                return false;
             }
             }
         }
         else // if !detail::is_terminal()
         {
-            std::cerr << R"(
-#######################################################################
-   Automatic Update Notifications
-#######################################################################
- This app performs automatic checks for updates. For more information
- see: https://docs.seqan.de/sharg/main_user/about_update_notifications.html
-#######################################################################
-
-)";
-            return true; // default: check version if you cannot ask the user
+            return false; // default: do not check version today, if you cannot ask the user
         }
     } // LCOV_EXCL_STOP