Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Remove dependency of seqan3::detail::type_name_as_string in format_base. #15

Closed
4 of 5 tasks
smehringer opened this issue Dec 1, 2021 · 0 comments · Fixed by #40
Closed
4 of 5 tasks
Assignees

Comments

@smehringer
Copy link
Member

smehringer commented Dec 1, 2021

Since we need this, we need to copy it over.

Blocked by #7

Tasks:

  • Copy over seqan3/utility/detail/type_name_as_string.hpp to sharg/detail/type_name_as_string.hpp and change the namespace to sharg
  • Copy over the type_name_as_string unit test.
  • Change the respective include in format_base.hpp from seqan3 to sharg.
  • Check if all tests pass
  • Tick off format_base in [FEATURE] Make the argument parser independent of seqan3. #6 since it does not include a seqan3 file anymore.
@smehringer smehringer changed the title [MISC] Remove dependency of seqan3::detail::type_name_as_stringin format_base. [MISC] Remove dependency of seqan3::detail::type_name_as_string in format_base. Dec 1, 2021
@smehringer smehringer assigned smehringer and unassigned smehringer Dec 7, 2021
@Irallia Irallia self-assigned this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants