Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check #236

Open
eseiler opened this issue Feb 10, 2024 · 0 comments
Open

Version check #236

eseiler opened this issue Feb 10, 2024 · 0 comments

Comments

@eseiler
Copy link
Member

eseiler commented Feb 10, 2024

We should check that the documented behavior reflects the actual behavior. For example,

#######################################################################
Automatic Update Notifications
#######################################################################
This app can look for updates automatically in the background,
do you want to do that?
[a] Always perform version checks for this app (the default).
[n] Never perform version checks for this app.
[y] Yes, perform a version check now, and ask again tomorrow.
[s] Skip the version check now, but ask again tomorrow.
Please enter one of [a, n, y, s] and press [RETURN].
For more information, see:
https://docs.seqan.de/sharg/main_user/about_update_notifications.html
#######################################################################

Says that the default is yes, but it is actually (and should be) never.

Personally, I often have to double check what version_check::on does. It doesn't mean always, but rather that it should ask the user. So maybe version_check::ask would be a better name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant