-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Adapt the version checker to sharg. #38
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/sharg-parser/EqjNxhw3p2tD3dsa3K8pH2bdDB2o |
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 95.63% 95.43% -0.21%
==========================================
Files 12 13 +1
Lines 894 920 +26
==========================================
+ Hits 855 878 +23
- Misses 39 42 +3
Continue to review full report at Codecov.
|
ae53a88
to
652e7dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks good to me 👍
|
||
TEST_F(version_check, option_off_with_help_page) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good split! much nicer!
// This is not an actual check s.t. the test does not fail because there is something wrong with | ||
// the server in Tuebingen. But upon manual execution of the test this can give valuable insight | ||
// on whats happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rephrase that?
I don't understand it.
Do you mean that this test succeeds even if the server is down?
manual execution
as opposed to what?
And what kind of insight you may get?
It seems more like debug output, not like a log of what was happening.
Co-authored-by: Enrico Seiler <eseiler@users.noreply.github.com>
|
Part of #31
Prior to this PR the following has been done:
Add sharg version to version.txt file OpenMS/usage_plots#19
.../SeqAn-Sharg
(instead ofSeqAn3
). See full script hereThis PR does the following (by commit):
Exceptions (Open TODO): Notifications still link to seqan3 wiki page
SeqAn-Sharg
to get correct cookies