Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Adapt the version checker to sharg. #38

Merged
merged 6 commits into from
Jan 5, 2022
Merged

[FEATURE] Adapt the version checker to sharg. #38

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56cbf61
[MISC] Adapt version check functionality to sharg.
smehringer Dec 1, 2021
29cdf1b
[FEATURE] Triggers Sharg version to be returned from the server.
smehringer Dec 17, 2021
c7ca854
[TEST] Print server cookie.
smehringer Dec 17, 2021
652e7dc
[TEST] Split version_check - option_off test.
smehringer Dec 17, 2021
9f3b9c1
Apply suggestions from code review
smehringer Jan 5, 2022
3fd85dd
Rephrase cookie debugging
smehringer Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/unit/detail/version_check_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,12 @@ TEST_F(version_check, option_off)
EXPECT_FALSE(std::filesystem::exists(app_timestamp_filename())) << app_timestamp_filename();

EXPECT_TRUE(remove_files_from_path()); // clear files again
}

TEST_F(version_check, option_off_with_help_page)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good split! much nicer!

{
// Version check option always needs to be parsed, even if special formats get selected
const char * argv2[4] = {app_name.c_str(), "-h", OPTION_VERSION_CHECK, OPTION_OFF};
const char * argv[4] = {app_name.c_str(), "-h", OPTION_VERSION_CHECK, OPTION_OFF};

std::string previous_value{};
if (char * env = std::getenv("SHARG_NO_VERSION_CHECK"))
Expand All @@ -353,7 +356,7 @@ TEST_F(version_check, option_off)
unsetenv("SHARG_NO_VERSION_CHECK");
}

sharg::argument_parser parser{app_name, 4, argv2};
sharg::argument_parser parser{app_name, 4, argv};
parser.info.version = "2.3.4";

EXPECT_EXIT(parser.parse(), ::testing::ExitedWithCode(EXIT_SUCCESS), "");
Expand Down