Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Remove dependency of seqan3::detail::type_name_as_string. #40

Conversation

Irallia
Copy link
Contributor

@Irallia Irallia commented Dec 20, 2021

Resolves #15

New seqan3 includes in the new test file:
#include <seqan3/utility/type_list/traits.hpp>
#include <seqan3/utility/type_list/type_list.hpp>

@Irallia Irallia self-assigned this Dec 20, 2021
@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/sharg-parser/8ndSsGBBaZrNiUsL2wuRWj9AetxQ
✅ Preview: https://sharg-parser-git-fork-irallia-misc-removedependenc-50e5aa-seqan.vercel.app

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #40 (c315cd7) into master (c67fef4) will increase coverage by 0.63%.
The diff coverage is 100.00%.

❗ Current head c315cd7 differs from pull request most recent head a2bbb08. Consider uploading reports for the commit a2bbb08 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   94.90%   95.54%   +0.63%     
==========================================
  Files          12       13       +1     
  Lines         903      920      +17     
==========================================
+ Hits          857      879      +22     
+ Misses         46       41       -5     
Impacted Files Coverage Δ
include/sharg/detail/format_base.hpp 93.16% <100.00%> (+3.07%) ⬆️
include/sharg/detail/format_parse.hpp 97.43% <100.00%> (+0.72%) ⬆️
include/sharg/detail/type_name_as_string.hpp 100.00% <100.00%> (ø)
include/sharg/detail/version_check.hpp 93.18% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67fef4...a2bbb08. Read the comment docs.

@Irallia Irallia requested review from a team and MitraDarja and removed request for a team December 20, 2021 17:36
@Irallia
Copy link
Contributor Author

Irallia commented Dec 20, 2021

Is there a way to avoid the new includes or should I open new Issues / follow up PRs for these?

Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if these suggestions work?
Note that you need to adapt the if block with all the types

test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Show resolved Hide resolved
@Irallia
Copy link
Contributor Author

Irallia commented Dec 21, 2021

Can you check if these suggestions work? Note that you need to adapt the if block with all the types

That works, thank you!

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

include/sharg/detail/format_base.hpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
test/unit/detail/type_name_as_string_test.cpp Outdated Show resolved Hide resolved
@eseiler
Copy link
Member

eseiler commented Dec 21, 2021

I think you can do a rebase on current master, and then this is good to go :)

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the MISC/Remove_dependency_of_seqan3_type_name_as_string branch from c315cd7 to a2bbb08 Compare December 21, 2021 11:18
@eseiler eseiler requested review from smehringer and removed request for MitraDarja December 21, 2021 12:28
@smehringer smehringer merged commit 27a1533 into seqan:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MISC] Remove dependency of seqan3::detail::type_name_as_string in format_base.
4 participants