Skip to content

Commit

Permalink
Remove _NorthwindLayout, use esbuild's css import system, remove Nort…
Browse files Browse the repository at this point in the history
…hwind/index.css, use Html.ModulePageInit extension so that css files are also included automatically
  • Loading branch information
volkanceylan committed Oct 10, 2024
1 parent e2fb421 commit e51cdd7
Show file tree
Hide file tree
Showing 54 changed files with 87 additions and 171 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ out/
.vs/
/build/.nupkg/
node_modules/
/src/*/dist/index.css
/src/*/dist/index.css.map
/src/*/dist/index.js
/src/*/dist/index.min.js
/src/*/dist/index.js.map
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@
<div id="SampleRoot">
</div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("ChartInDialogPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.ChartInDialogPage)
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("CloneableEntityDialogPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.CloneableEntityDialogPage)
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("DefaultValuesInNewDialogPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.DefaultValuesInNewDialogPage)
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@

<div id="SampleRoot" class="d-flex gap-1"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("DialogBoxesPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.DialogBoxesPage)
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,4 @@

<div id="DialogDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("EntityDialogAsPanelPage.js"))';
pageInit(@Json.Serialize(Model));
</script>
@Html.ModulePageInit(ESM.EntityDialogAsPanelPage)
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@{
@{
ViewData["Title"] = "Get Inserted Record Id From Dialog";
}

Expand Down Expand Up @@ -26,7 +26,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("GetInsertedRecordIdPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.GetInsertedRecordIdPage)
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("OtherFormInTabPage.js"))';
pageInit();
</script>
@HTML.ModulePageInit(ESM.OtherFormInTabPage)
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,4 @@
<div id="GridDiv"></div>


<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("OtherFormInTabOneBarPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.OtherFormInTabOneBarPage)
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("PopulateLinkedDataPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.PopulateLinkedDataPage)
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("ReadOnlyDialogPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.ReadOnlyDialogPage)
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@{
@{
ViewData["Title"] = "Serial Auto Numbering";
}

Expand Down Expand Up @@ -28,9 +28,7 @@
</p>
</div>


<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("SerialAutoNumberPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.SerialAutoNumberPage)
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@
</p>
</div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("ChangingLookupTextPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.ChangingLookupTextPage)
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("FilteredLookupInDetailPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.FilteredLookupInDetailPage)
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("LookupFilterByMultipleValuesPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.LookupFilterByMultipleValuesPage)
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,4 @@
<input type="hidden" />
</div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("SelectWithHardcodedValuesPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.SelectWithHardcodedValuesPage)
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@
</p>
</div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("StaticTextBlockPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.StaticTextBlockPage)
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("CustomLinksInGridPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.CustomLinksInGridPage)
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("EnablingRowSelectionPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.EnablingRowSelectionPage)
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("GridFilteredByCriteriaPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.GridFilteredByCriteriaPage)
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@{
@{
ViewData["Title"] = "Grouping and Summaries In Grid";
}

Expand All @@ -19,7 +19,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("GroupingAndSummariesInGridPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.GroupingAndSummariesInGridPage)
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("InitialValuesForQuickFiltersPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.InitialValuesForQuickFiltersPage)
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("InlineActionButtonsPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.InlineActionButtonsPage)
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("InlineImageInGridPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.InlineImageInGridPage)
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("RemovingAddButtonPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.RemovingAddButtonPage)
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("ViewWithoutIDPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.ViewWithoutIDPage)
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(Html.BasicSamplesModuleFile("WrappedHeadersPage.js"))';
pageInit();
</script>
@Html.ModulePageInit(ESM.WrappedHeadersPage)
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@{
Layout = "_Layout";
}
@Html.Stylesheet("~/Serenity.Demo.Northwind/index.css")
@Html.Stylesheet("~/Serenity.Demo.BasicSamples/index.css")
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Decorators, gridPageInit } from "@serenity-is/corelib";
import { CustomerDialog, CustomerGrid, CustomerService } from "@serenity-is/demo.northwind";
import "@serenity-is/demo.northwind/dist/index.css";

export default () => gridPageInit(SerialAutoNumberGrid);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,4 @@

<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(ESM.OrderPage)';
pageInit();
</script>
@Html.ModulePageInit(ESM.OrderPage)
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@
}
<div id="GridDiv"></div>

<script type="module">
import pageInit from '@Html.ResolveWithHash(ESM.ProductPage)';
pageInit();
</script>
@Html.ModulePageInit(ESM.ProductPage)

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@{
@{
Layout = "_Layout";
}
@Html.Stylesheet("~/Serenity.Demo.Northwind/index.css")
1 change: 0 additions & 1 deletion src/Serenity.Demo.Northwind/Imports/MVC/MVC.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ namespace Serenity.Demo.Northwind.MVC;

public static class Views
{
public const string _NorthwindLayout = "~/Areas/Serenity.Demo.Northwind/_NorthwindLayout.cshtml";
public static class Order
{
public const string OrderDetailReport = "~/Areas/Serenity.Demo.Northwind/Order/OrderDetailReport.cshtml";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ public class CategoryPage : Controller
[Route("Northwind/Category")]
public ActionResult Index()
{
return this.GridPage<CategoryRow>(ESM.CategoryPage, layout: MVC.Views._NorthwindLayout);
return this.GridPage<CategoryRow>(ESM.CategoryPage);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.s-Demo-Northwind-CustomerDialog .s-NotesEditor {
flex: 1 1 auto;
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { CustomerForm, CustomerRow, CustomerService } from "../ServerTypes/Demo"
import { Decorators, EntityDialog, TabsExtensions, WidgetProps, htmlEncode, localText, reloadLookup } from "@serenity-is/corelib";
import { DialogUtils } from "@serenity-is/extensions";
import { CustomerOrdersGrid } from "./CustomerOrdersGrid";
import "./CustomerDialog.css";

@Decorators.registerClass('Serenity.Demo.Northwind.CustomerDialog')
export class CustomerDialog<P = {}> extends EntityDialog<CustomerRow, P> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class CustomerPage : Controller
[Route("Northwind/Customer")]
public ActionResult Index()
{
return this.GridPage<CustomerRow>(ESM.CustomerPage, layout: MVC.Views._NorthwindLayout);
return this.GridPage<CustomerRow>(ESM.CustomerPage);
}
}

Expand Down
Loading

0 comments on commit e51cdd7

Please sign in to comment.