Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.unwrap_or_default() instead of falling back to "<prefix>" in single-command help #255

Closed
wants to merge 2 commits into from

Conversation

SIGSTACKFAULT
Copy link

fixes #254

unifies prefix logic between help_single_command and help_all_commands
@kangalio
Copy link
Collaborator

Hi, thanks for the fix! Reading the code comments in the removed code, I would prefer you make the fallback string configurable, bc for dynamic prefixes, an empty string is not a good fallback either

@SIGSTACKFAULT
Copy link
Author

SIGSTACKFAULT commented Mar 26, 2024

@kangalio help_all_commands already falls back to not showing any prefix here so i copied that logic.

I think this whole file would need a bit of a rewrite

@jamesbt365
Copy link
Member

Just a heads up, help commands on next have been removed as the code quality is shockingly bad, and they aren't worth maintaining in the crate. #323 should explain it, and a potential path for moving forward.

@GnomedDev
Copy link
Member

Yeah, let's avoid adding more to this when it needs a rewrite.

@GnomedDev GnomedDev closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single-command help shows <prefix> for bot with no prefix
4 participants