Get rid of numpy.distutils #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge-sans-paille
force-pushed
the
fix/get-rid-of-numpy-distutils
branch
13 times, most recently
from
0ff15be to
3be9524
Compare
hroncok
reviewed
Oct 16, 2023
docs/DEVGUIDE.rst
Outdated
| validation suite is run through the command:: | ||
| <http://pytest.org/latest/>`_ package to manage test cases. | ||
|
|
||
| All requirementsa r elisted in ``pythran/tests/requirements.txt``. |
There was a problem hiding this comment.
Suggested change
| All requirementsa r elisted in ``pythran/tests/requirements.txt``. | |
| All requirements are listed in ``pythran/tests/requirements.txt``. |
rgommers
approved these changes
Oct 18, 2023
This adds a dependency on setuptools and get rids of references to numpy.distutils and (part of) distutils. Fix #2148
serge-sans-paille
force-pushed
the
fix/get-rid-of-numpy-distutils
branch
from
3be9524 to
5b76f66
Compare
|
Thanks @hroncok, @musicinmybrain and @rgommers for extra-testing this patch. |
|
@serge-sans-paille would you please consider releasing a new version that contains these changes? |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since numpy 1.26.0, numpy.distutils is being removed in python 3.12, let's try to have a solution that work for 3.12 and previous version without numpy.distutils.
Fix #2148