Specialize graph.all_simple_paths for pythran case #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating all possible paths from src to dst and checking them, check while flooding the graph, which is much less costly. As a side effect, remove graph.all_simple_paths, which was previously used and responsible fro the performance issue. Fix #2216
serge-sans-paille
force-pushed
the
fix/2216
branch
from
9aeddd0 to
7e24de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always have one source and one target, so specialize the algorithm for this setup, which should greatly reduce the execution time of #2216
As a side effect, introduce a minimal test suite for graph.all_simple_paths, adapted from networkx test suite.