Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: improvements to pythran-config for build system integration #2270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgommers
Copy link
Contributor

xref gh-2257. Putting this up for discussion early, with some comments. I considered adding --config compiler.blas=none|openblas support, but that then also has to interact with --cflags etc., so it's not clear that that works well for inclusion in 0.17.1 - and this can be added later.

The --cflags-pythran-only is the only thing we need for SciPy. It allows me to remove all this special handling:
https://github.com/scipy/scipy/blob/b98e79e4b326bf3beb4d861a744101ee7f438471/scipy/meson.build#L103-L138

and replace it with:

pythran_dep = []
if use_pythran
  pythran_dep = dependency('pythran', version: '>=0.17.1')
endif

"exclusive, please use only one.")

compile_flags = [
"-D__PYTHRAN__=3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed __PYTHRAN__ in 075cefc

compile_flags = [
"-D__PYTHRAN__=3",
"-DENABLE_PYTHON_MODULE",
"-DPYTHRAN_BLAS_NONE",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this blas flag is the one you need for scipy, but it should really depend on current config.

You mentioned

I considered adding --config compiler.blas=none|openblas support, but that then also has to interact with --cflags etc., so it's not clear that that works well for inclusion in 0.17.1 - and this can be added later.

In the gommit message but I think that's fine, it should just be also forwaded to extension = pythran.config.make_extension(python=args.python) below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks, I'll see if I can figure out how to introduce this now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants