-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that a NullPointerException occurs when initialize the unified configuration #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanbingleixue
changed the title
Fixed the issue where a NullPointerException would occur when the a type of the configuration item is a collection and the configuration content is empty.
Fix the issue that a NullPointerException occurs during configuration initialization parsing.
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs during configuration initialization parsing.
Fix the issue that a NullPointerException occurs during configuration initialization parsing
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs during configuration initialization parsing
Fix the issue that a NullPointerException occurs when the configuration item type is set and the configuration content is empty during configuration initialization parsing
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs when the configuration item type is set and the configuration content is empty during configuration initialization parsing
Fix the issue that a NullPointerException occurs when during configuration initialization parsing
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs when during configuration initialization parsing
Fix the issue that a NullPointerException occurs when configuration initialization parsing
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs when configuration initialization parsing
Fix the issue that a NullPointerException occurs when parsing the configuration initialization
Aug 5, 2024
hanbingleixue
changed the title
Fix the issue that a NullPointerException occurs when parsing the configuration initialization
Fix the issue that a NullPointerException occurs when initialize the unified configuration
Aug 5, 2024
daizhenyu
reviewed
Aug 6, 2024
...ant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/event/EventCollector.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
develop
branch
2 times, most recently
from
August 6, 2024 02:36
43e12ad
to
56db5c9
Compare
lilai23
reviewed
Aug 6, 2024
...ant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/event/EventCollector.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 6, 2024
...ant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/event/EventCollector.java
Outdated
Show resolved
Hide resolved
…a type of the configuration item is a collection and the configuration content is empty. Signed-off-by: hanbingleixue <hanbingleixue@hotmail.com>
daizhenyu
approved these changes
Aug 6, 2024
lilai23
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does / why we need it?
Fix the issue that a NullPointerException occurs when the configuration item type is set and the configuration content is empty during configuration initialization parsing. When the configuration type of a configuration item is collection and the configuration content is empty, an warning log is recorded. The LogEventCollector collects and reports warning logs. However, the event configuration is not initialized, so a NullPointerException is thrown on event collection
Which issue(s) this PR fixes?
Fixes #1591
Does this PR introduce a user-facing change?
No
Checklist