Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

合并为增强引导类加载器加载的类而定制的Template、Transform #1252

Merged

Conversation

luanwenfei-venus
Copy link
Collaborator

【修复issue】#1234

【修改内容】1、新增AdviserScheduler,用于调度Sermant中的Adviser,AdviserInterface用于限制Adviser的能力 2、新增sermant-agentcore-god模块,用于放置需要全局可见的类ExecuteContext、Interceptor、AdviserScheduler、AdviserInterface 3、合并构造函数模板为TemplateForCtor、合并成员函数模板为TemplateForMember、合并静态函数模板为TemplateForStatic 4、合并Transformer为DefaultTransformer

【用例描述】不改变原有功能,不需新增用例

【自测情况】1、本地静态检查已过;2、测试用例暂未自动化

【影响范围】1、新增sermant-agentcore-god包,需要配合文档修改

@luanwenfei-venus luanwenfei-venus added area/framework Issues or PRs releated to sermant core service kind/refactor labels Jul 18, 2023
@luanwenfei-venus luanwenfei-venus self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 0.58% and project coverage change: +0.35% 🎉

Comparison is base (5680849) 41.64% compared to head (ba541e4) 42.00%.
Report is 19 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1252      +/-   ##
=============================================
+ Coverage      41.64%   42.00%   +0.35%     
+ Complexity      3219     3197      -22     
=============================================
  Files            817      815       -2     
  Lines          18032    17740     -292     
  Branches        1961     1934      -27     
=============================================
- Hits            7509     7451      -58     
+ Misses          9578     9358     -220     
+ Partials         945      931      -14     
Flag Coverage Δ
unittests 42.00% <0.58%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...om/huaweicloud/sermant/core/AgentCoreEntrance.java 0.00% <0.00%> (ø)
...ermant/core/plugin/agent/BufferedAgentBuilder.java 0.00% <0.00%> (ø)
...plugin/agent/collector/PluginCollectorManager.java 0.00% <0.00%> (ø)
.../core/plugin/agent/template/BaseAdviseHandler.java 0.00% <0.00%> (ø)
...ant/core/plugin/agent/template/DefaultAdviser.java 0.00% <0.00%> (ø)
...nt/core/plugin/agent/template/TemplateForCtor.java 0.00% <0.00%> (ø)
.../core/plugin/agent/template/TemplateForMember.java 0.00% <0.00%> (ø)
.../core/plugin/agent/template/TemplateForStatic.java 0.00% <0.00%> (ø)
...e/plugin/agent/transformer/DefaultTransformer.java 0.00% <0.00%> (ø)
...com/huaweicloud/sermant/core/utils/ClassUtils.java 51.61% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 4427972 into sermant-io:develop Jul 29, 2023
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants