Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复injector挂载sermant会跟skywalking产生冲突的问题 #1262

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

provenceee
Copy link
Collaborator

【修复issue】 #1258

【修改内容】修改injector注入命令的行为

【用例描述】注入行为分别为before、after、ignore时,是否可以按预期注入命令

【自测情况】before时,在原命令前注入,after时,在原命令后注入,ignore时,不注入

【影响范围】需要更新文档

@provenceee provenceee added kind/bug Something isn't working area/injector Issues or PRs releated to sermant injector labels Jul 26, 2023
@provenceee provenceee self-assigned this Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (3e4f10e) 41.63% compared to head (fcc9a8d) 41.51%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.1.x    #1262      +/-   ##
============================================
- Coverage     41.63%   41.51%   -0.13%     
+ Complexity     3219     3212       -7     
============================================
  Files           817      817              
  Lines         18029    18029              
  Branches       1960     1960              
============================================
- Hits           7507     7485      -22     
- Misses         9577     9606      +29     
+ Partials        945      938       -7     
Flag Coverage Δ
unittests 41.51% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 7a16d17 into sermant-io:1.1.x Jul 27, 2023
3 checks passed
@provenceee provenceee deleted the injector-dev-1.1.x branch August 2, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/injector Issues or PRs releated to sermant injector kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants