Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化springcloud双注册场景,DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor处理逻辑 #1267

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

TangLeDaily
Copy link
Collaborator

【修复issue】#1242

【修改内容】
1、修改了com.huawei.registry.interceptors.DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor的拦截逻辑,去掉线程变量,修改合并方式
2、修改了相应的UT

【用例描述】功能不变,不需要修改用例

【自测情况】本地静态检查通过、UT通过

【影响范围】不涉及

@TangLeDaily TangLeDaily self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 78.43% and project coverage change: +0.37% 🎉

Comparison is base (4427972) 42.00% compared to head (410a241) 42.37%.
Report is 15 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1267      +/-   ##
=============================================
+ Coverage      42.00%   42.37%   +0.37%     
- Complexity      3197     3232      +35     
=============================================
  Files            815      821       +6     
  Lines          17740    17894     +154     
  Branches        1934     1950      +16     
=============================================
+ Hits            7451     7583     +132     
- Misses          9358     9360       +2     
- Partials         931      951      +20     
Flag Coverage Δ
unittests 42.37% <78.43%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...try/interceptors/DynamicServerListInterceptor.java 58.06% <0.00%> (ø)
...nterceptors/DiscoveryClientServiceInterceptor.java 69.23% <76.47%> (ø)
...istry/interceptors/DiscoveryClientInterceptor.java 86.66% <83.33%> (+14.16%) ⬆️
...i/registry/support/InstanceInterceptorSupport.java 84.00% <100.00%> (+6.58%) ⬆️

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TangLeDaily TangLeDaily force-pushed the issue1242_a branch 3 times, most recently from 1731724 to 26ee735 Compare August 10, 2023 07:40
@luanwenfei-venus luanwenfei-venus added area/plugin Issues or PRs releated to sermant plugin service kind/bug Something isn't working labels Aug 10, 2023
@Sherlockhan Sherlockhan merged commit 459d747 into sermant-io:develop Aug 23, 2023
63 checks passed
@luanwenfei-venus luanwenfei-venus added kind/enhancement Issues or PRs releated to sermant enhancement and removed kind/bug Something isn't working labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants