-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
优化springcloud双注册场景,DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor处理逻辑 #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1267 +/- ##
=============================================
+ Coverage 42.00% 42.37% +0.37%
- Complexity 3197 3232 +35
=============================================
Files 815 821 +6
Lines 17740 17894 +154
Branches 1934 1950 +16
=============================================
+ Hits 7451 7583 +132
- Misses 9358 9360 +2
- Partials 931 951 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
...gistry-plugin/src/main/java/com/huawei/registry/interceptors/DiscoveryClientInterceptor.java
Outdated
Show resolved
Hide resolved
...gistry-plugin/src/main/java/com/huawei/registry/interceptors/DiscoveryClientInterceptor.java
Outdated
Show resolved
Hide resolved
...in/src/test/java/com/huawei/registry/interceptors/DiscoveryClientServiceInterceptorTest.java
Show resolved
Hide resolved
TangLeDaily
force-pushed
the
issue1242_a
branch
3 times, most recently
from
August 10, 2023 07:40
1731724
to
26ee735
Compare
luanwenfei-venus
added
area/plugin
Issues or PRs releated to sermant plugin service
kind/bug
Something isn't working
labels
Aug 10, 2023
luanwenfei-venus
previously approved these changes
Aug 11, 2023
...gistry-plugin/src/main/java/com/huawei/registry/interceptors/DiscoveryClientInterceptor.java
Show resolved
Hide resolved
...gistry-plugin/src/main/java/com/huawei/registry/interceptors/DiscoveryClientInterceptor.java
Show resolved
Hide resolved
provenceee
reviewed
Aug 12, 2023
...gistry-plugin/src/main/java/com/huawei/registry/interceptors/DiscoveryClientInterceptor.java
Show resolved
Hide resolved
TangLeDaily
force-pushed
the
issue1242_a
branch
2 times, most recently
from
August 15, 2023 11:22
591987a
to
073b21a
Compare
…viceInterceptor的处理逻辑
TangLeDaily
force-pushed
the
issue1242_a
branch
from
August 15, 2023 12:04
073b21a
to
410a241
Compare
provenceee
approved these changes
Aug 22, 2023
luanwenfei-venus
approved these changes
Aug 22, 2023
luanwenfei-venus
added
kind/enhancement
Issues or PRs releated to sermant enhancement
and removed
kind/bug
Something isn't working
labels
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin
Issues or PRs releated to sermant plugin service
kind/enhancement
Issues or PRs releated to sermant enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】#1242
【修改内容】
1、修改了com.huawei.registry.interceptors.DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor的拦截逻辑,去掉线程变量,修改合并方式
2、修改了相应的UT
【用例描述】功能不变,不需要修改用例
【自测情况】本地静态检查通过、UT通过
【影响范围】不涉及