-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dubbo流量标签透传,支持2.6.x,2.7.x,3.x #1273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决代码冲突 |
PR描述不仅限于增删文件,需描述PR实现的东西,自测情况也许要具体描述 |
lilai23
reviewed
Aug 10, 2023
...smission-plugin/src/main/java/com/huaweicloud/sermant/tag/transmission/utils/DubboUtils.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...ain/java/com/huaweicloud/sermant/tag/transmission/declarers/ApacheDubboProviderDeclarer.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...in/java/com/huaweicloud/sermant/tag/transmission/declarers/AlibabaDubboProviderDeclarer.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
.../src/main/java/com/huaweicloud/sermant/tag/transmission/declarers/DubboConsumerDeclarer.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...a/com/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...a/com/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...a/com/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboProviderInterceptor.java
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...a/com/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...ain/java/com/huaweicloud/sermant/tag/transmission/interceptors/DubboConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
added
area/plugin
Issues or PRs releated to sermant plugin service
kind/feature
Issue for new feature
labels
Aug 10, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1273 +/- ##
==========================================
Coverage 42.34% 42.34%
Complexity 3230 3230
==========================================
Files 821 821
Lines 17895 17895
Branches 1947 1947
==========================================
Hits 7578 7578
Misses 9365 9365
Partials 952 952
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lilai23
reviewed
Aug 10, 2023
...smission-plugin/src/main/java/com/huaweicloud/sermant/tag/transmission/utils/DubboUtils.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...m/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboProviderInterceptorTest.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Aug 10, 2023
...om/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptorTest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/huaweicloud/sermant/tag/transmission/declarers/DubboConsumerDeclarer.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/huaweicloud/sermant/tag/transmission/declarers/DubboConsumerDeclarer.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
...sion-plugin/src/test/java/com/huaweicloud/sermant/tag/transmission/utils/DubboUtilsTest.java
Outdated
Show resolved
Hide resolved
daizhenyu
force-pushed
the
develop-dzy
branch
2 times, most recently
from
August 14, 2023 02:07
545286e
to
26e61ff
Compare
...a/com/huaweicloud/sermant/tag/transmission/interceptors/AlibabaDubboConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
.../com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboV2ConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
.../com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboV3ConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
...va/com/huaweicloud/sermant/tag/transmission/interceptors/ApacheDubboProviderInterceptor.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
previously approved these changes
Aug 14, 2023
lilai23
previously approved these changes
Aug 14, 2023
daizhenyu
dismissed stale reviews from lilai23 and luanwenfei-venus
via
August 14, 2023 10:52
1dd75e6
luanwenfei-venus
approved these changes
Aug 14, 2023
lilai23
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】#1244
【修改内容】
1.增加了ApacheDubboV3ConsumerDeclarer、ApacheDubboV2ConsumerDeclarer和AlibabaDubboConsumerDeclarer类,这三个类是dubbo流量标签透传在consumer端的声明类,分别适配不同的dubbo版本
2.增加了ApacheDubboProviderDeclarer和AlibabaDubboProviderDeclarer类,这两个类是dubbo流量标签透传在provider端的声明类,分别适配不同的dubbo版本
3.增加了AlibabaDubboConsumerInterceptor、AlibabaDubboProviderInterceptor、ApacheDubboProviderInterceptor、ApacheDubboV2ConsumerInterceptor和ApacheDubboV3ConsumerInterceptor五个拦截器,实现在拦截点的增强逻辑来实现流量标签透传功能
4.增加了DubboUtils工具类,作为dubbo流量标签透传的工具类使用
5.修改了pom文件,增加dubbo和单元测试所需的依赖
6.修改了com.huaweicloud.sermant.core.plugin.agent.declarer.PluginDeclarer文件
【用例描述】无
【自测情况】本地编译通过,针对dubbo2.6.x、2.7.x和3.x多个版本测试通过
【影响范围】需要修改文档