Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo流量标签透传,支持2.6.x,2.7.x,3.x #1273

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Aug 9, 2023

【修复issue】#1244

【修改内容】
1.增加了ApacheDubboV3ConsumerDeclarer、ApacheDubboV2ConsumerDeclarer和AlibabaDubboConsumerDeclarer类,这三个类是dubbo流量标签透传在consumer端的声明类,分别适配不同的dubbo版本
2.增加了ApacheDubboProviderDeclarer和AlibabaDubboProviderDeclarer类,这两个类是dubbo流量标签透传在provider端的声明类,分别适配不同的dubbo版本
3.增加了AlibabaDubboConsumerInterceptor、AlibabaDubboProviderInterceptor、ApacheDubboProviderInterceptor、ApacheDubboV2ConsumerInterceptor和ApacheDubboV3ConsumerInterceptor五个拦截器,实现在拦截点的增强逻辑来实现流量标签透传功能
4.增加了DubboUtils工具类,作为dubbo流量标签透传的工具类使用

5.修改了pom文件,增加dubbo和单元测试所需的依赖
6.修改了com.huaweicloud.sermant.core.plugin.agent.declarer.PluginDeclarer文件
【用例描述】无

【自测情况】本地编译通过,针对dubbo2.6.x、2.7.x和3.x多个版本测试通过

【影响范围】需要修改文档

@lilai23
Copy link
Collaborator

lilai23 commented Aug 10, 2023

解决代码冲突

@lilai23
Copy link
Collaborator

lilai23 commented Aug 10, 2023

PR描述不仅限于增删文件,需描述PR实现的东西,自测情况也许要具体描述

@luanwenfei-venus luanwenfei-venus added area/plugin Issues or PRs releated to sermant plugin service kind/feature Issue for new feature labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (815d7b7) 42.34% compared to head (1dd75e6) 42.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1273   +/-   ##
==========================================
  Coverage      42.34%   42.34%           
  Complexity      3230     3230           
==========================================
  Files            821      821           
  Lines          17895    17895           
  Branches        1947     1947           
==========================================
  Hits            7578     7578           
  Misses          9365     9365           
  Partials         952      952           
Flag Coverage Δ
unittests 42.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daizhenyu daizhenyu force-pushed the develop-dzy branch 2 times, most recently from 545286e to 26e61ff Compare August 14, 2023 02:07
lilai23
lilai23 previously approved these changes Aug 14, 2023
@Sherlockhan Sherlockhan merged commit a21b509 into sermant-io:develop Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants