Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

流量标签透传特性:支持 httpclient3、Okhttp2、Jdk httpclient的流量标签透传 & 重构代码结构和风格 #1281

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Aug 15, 2023

【修复issue】#1244

【修改内容】
(1)支持 httpclient3、Okhttp2、JDK httpclient的流量标签透传
(2) 重构代码结构和风格,抽象标签注入和解析方法

【用例描述】1、分别使用 httpclient3、Okhttp2、JDK httpclient发送 http 请求,Sermant 拦截并注入流量标签,查看服务端接受请求 header 中是否携带流量标签。

【自测情况】1、本地静态检查通过;2、本地自测通过;3、UT 待下一个 PR补充

【影响范围】无

@lilai23 lilai23 added kind/feature Issue for new feature area/plugin Issues or PRs releated to sermant plugin service kind/refactor labels Aug 15, 2023
@lilai23 lilai23 self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a21b509) 42.34% compared to head (19f2c21) 42.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1281   +/-   ##
==========================================
  Coverage      42.34%   42.34%           
  Complexity      3230     3230           
==========================================
  Files            821      821           
  Lines          17895    17895           
  Branches        1947     1947           
==========================================
  Hits            7578     7578           
  Misses          9365     9365           
  Partials         952      952           
Flag Coverage Δ
unittests 42.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilai23 lilai23 added this to the v1.2.0 milestone Aug 15, 2023
hanbingleixue
hanbingleixue previously approved these changes Aug 16, 2023
(1)支持 httpclient3、Okhttp2、Jdk httpclient的流量标签透传
(2) 重构代码结构和风格,抽象标签注入和解析方法
@Sherlockhan Sherlockhan merged commit 09f771e into sermant-io:develop Aug 16, 2023
3 checks passed
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants