-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
流量标签透传特性:支持 httpclient3、Okhttp2、Jdk httpclient的流量标签透传 & 重构代码结构和风格 #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilai23
added
kind/feature
Issue for new feature
area/plugin
Issues or PRs releated to sermant plugin service
kind/refactor
labels
Aug 15, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1281 +/- ##
==========================================
Coverage 42.34% 42.34%
Complexity 3230 3230
==========================================
Files 821 821
Lines 17895 17895
Branches 1947 1947
==========================================
Hits 7578 7578
Misses 9365 9365
Partials 952 952
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Show resolved
Hide resolved
...eicloud/sermant/tag/transmission/interceptors/rpc/dubbo/AlibabaDubboConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
...weicloud/sermant/tag/transmission/interceptors/rpc/dubbo/ApacheDubboConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
...weicloud/sermant/tag/transmission/declarers/http/client/httpclient/HttpClient3xDeclarer.java
Outdated
Show resolved
Hide resolved
...om/huaweicloud/sermant/tag/transmission/declarers/http/client/jdk/JdkHttpClientDeclarer.java
Outdated
Show resolved
Hide resolved
.../com/huaweicloud/sermant/tag/transmission/declarers/http/client/okhttp/OkHttp2xDeclarer.java
Outdated
Show resolved
Hide resolved
lilai23
force-pushed
the
tag_transmission
branch
from
August 16, 2023 02:36
908318d
to
df631f6
Compare
hanbingleixue
previously approved these changes
Aug 16, 2023
...in/java/com/huaweicloud/sermant/tag/transmission/interceptors/AbstractClientInterceptor.java
Outdated
Show resolved
Hide resolved
(1)支持 httpclient3、Okhttp2、Jdk httpclient的流量标签透传 (2) 重构代码结构和风格,抽象标签注入和解析方法
lilai23
force-pushed
the
tag_transmission
branch
from
August 16, 2023 06:30
df631f6
to
19f2c21
Compare
luanwenfei-venus
approved these changes
Aug 16, 2023
hanbingleixue
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】#1244
【修改内容】
(1)支持 httpclient3、Okhttp2、JDK httpclient的流量标签透传
(2) 重构代码结构和风格,抽象标签注入和解析方法
【用例描述】1、分别使用 httpclient3、Okhttp2、JDK httpclient发送 http 请求,Sermant 拦截并注入流量标签,查看服务端接受请求 header 中是否携带流量标签。
【自测情况】1、本地静态检查通过;2、本地自测通过;3、UT 待下一个 PR补充
【影响范围】无