Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK17支持:升级Lombok版本、ByteBuddy版本、新增Shenandoah收集器指标信息 #1293

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

TangLeDaily
Copy link
Collaborator

@TangLeDaily TangLeDaily commented Aug 30, 2023

【修复issue】#1283

【修改内容】

  1. 升级了Lombok版本1.18.10至1.18.22 (此版本起开始支持JDK17)
  2. 升级了ByteBuddy版本1.10.14至1.12.19 (1.10.21版本起开始支持JDK17)
  3. 修改了monitor插件中性能指标,增加了JDK17新增的Shenandoah收集器指标

【用例描述】修改了monitor集成测试性能指标遍历。原因:JDK17后新增了一些指标,需要根据不同版本适配更改

【自测情况】本地静态检查通过;UT通过;

【影响范围】monitor可采集的指标更改,文档需要更新

@TangLeDaily TangLeDaily self-assigned this Aug 30, 2023
@TangLeDaily TangLeDaily added this to the v1.2.0 milestone Aug 30, 2023
@TangLeDaily TangLeDaily added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service area/e2e-test Issues or PRs releated to e2e test labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.67% ⚠️

Comparison is base (a023e50) 41.98% compared to head (06a15a5) 41.31%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1293      +/-   ##
=============================================
- Coverage      41.98%   41.31%   -0.67%     
- Complexity      3220     3222       +2     
=============================================
  Files            824      827       +3     
  Lines          17984    18287     +303     
  Branches        1953     1991      +38     
=============================================
+ Hits            7551     7556       +5     
- Misses          9480     9781     +301     
+ Partials         953      950       -3     
Flag Coverage Δ
unittests 41.31% <0.00%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ermant/core/plugin/agent/BufferedAgentBuilder.java 0.00% <0.00%> (ø)
...plugin/agent/collector/PluginCollectorManager.java 0.00% <0.00%> (ø)
...e/plugin/agent/transformer/DefaultTransformer.java 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilai23
Copy link
Collaborator

lilai23 commented Sep 4, 2023

升级了Lombok版本1.18.10至1.18.22
升级了ByteBuddy版本1.10.14至1.10.21

描述下为什么需要升级这两个版本

hanbingleixue
hanbingleixue previously approved these changes Sep 4, 2023
lilai23
lilai23 previously approved these changes Sep 4, 2023
@Sherlockhan Sherlockhan merged commit 7645265 into sermant-io:develop Sep 6, 2023
68 checks passed
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-test Issues or PRs releated to e2e test area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants